util: add hex colors support in `styleText` by araujogui · Pull Request #61556 · nodejs/node

araujogui · 2026-01-28T01:00:57Z

codecov · 2026-01-28T01:53:55Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.72%. Comparing base (0dfdec9) to head (c01e52b).
⚠️ Report is 38 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #61556   +/-   ##
=======================================
  Coverage   89.71%   89.72%           
=======================================
  Files         695      695           
  Lines      214154   214220   +66     
  Branches    41009    41018    +9     
=======================================
+ Hits       192132   192208   +76     
+ Misses      14075    14073    -2     
+ Partials     7947     7939    -8

Files with missing lines	Coverage Δ
lib/util.js	`94.25% <100.00%> (+0.67%)`	⬆️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ljharb

Please add test cases for invalid values.

lib/util.js

nodejs-github-bot · 2026-02-08T22:25:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71262/

doc/api/util.md

nodejs-github-bot · 2026-02-18T22:49:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71369/

RafaelGSS

Since we don't have a green CI yet, would you mind including hex to styleText benchmarks? We are working to improve that, and it would be interesting to see if this decreases performance.

Copilot

Pull request overview

Adds support for passing hex color strings (e.g. #ffcc00, #fc0) to util.styleText() by emitting ANSI TrueColor (24-bit) foreground escape sequences, along with tests/docs/bench updates.

Changes:

Extend util.styleText() to recognize #RGB / #RRGGBB formats and generate 38;2;r;g;b ANSI sequences.
Add a new parallel test suite covering valid/invalid hex handling and env/TTY behavior.
Update util API docs and the existing styleText benchmark to include a hex format case.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
`lib/util.js`	Implements hex color parsing and ANSI sequence generation inside `styleText()`.
`test/parallel/test-util-styletext-hex.js`	Adds comprehensive tests for hex parsing, composition with modifiers, invalid inputs, and env behavior.
`doc/api/util.md`	Documents hex color support for `util.styleText()`.
`benchmark/util/style-text.js`	Adds a hex format option to benchmark `styleText()`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/parallel/test-util-styletext-hex.js

lib/util.js

araujogui · 2026-04-01T18:48:30Z

@araujogui at this point I'd probably recommend you checking if you're able to reproduce these errors, it is so consistently failing on windows-fanned that I'm starting to believe it is not flakiness but actual failures.

I've attached logs. And it is always these two contenders.

2,win11-arm64-COMPILED_BY-vs2022_clang-arm64.txt

1,win10-COMPILED_BY-vs2022_clang.txt

It's http and net tests that are flaky 😅

https://gist.github.com/araujogui/df02946a26166615c857f49cce19e73f

Rebased the PR again, maybe this solve the problem

nodejs-github-bot · 2026-04-02T13:50:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72425/

nodejs-github-bot · 2026-04-06T04:08:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72501/

nodejs-github-bot · 2026-04-06T08:21:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72503/

nodejs-github-bot · 2026-04-06T11:11:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72513/

ovflowd · 2026-04-06T21:51:51Z

(╯°□°）╯︵ ┻━┻

nodejs-github-bot · 2026-04-07T08:50:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72528/

nodejs-github-bot · 2026-04-07T11:13:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72532/

nodejs-github-bot · 2026-04-07T13:03:37Z

Commit Queue failed

- Loading data for nodejs/node/pull/61556
✔  Done loading data for nodejs/node/pull/61556
----------------------------------- PR info ------------------------------------
Title      util: add hex colors support in `styleText` (#61556)
Author     Guilherme Araújo <arauujogui@gmail.com> (@araujogui)
Branch     araujogui:util/colorize-hex -> nodejs:main
Labels     util, semver-minor, author ready, needs-ci, commit-queue-squash
Commits    9
 - util: colorize text with hex colors
 - util: nits
 - util: non-capturing regex
 - util: return buffer
 - doc: add history entry
 - doc: add final period
 - doc: profread
 - util: remove unused import
 - benchmark: add hex style
Committers 1
 - Guilherme Araújo <arauujogui@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/61556
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61556
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 28 Jan 2026 01:00:57 GMT
   ✔  Approvals: 8
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/61556#pullrequestreview-3723149200
   ✔  - Jordan Harband (@ljharb): https://github.com/nodejs/node/pull/61556#pullrequestreview-3724564626
   ✔  - René (@Renegade334): https://github.com/nodejs/node/pull/61556#pullrequestreview-3769858571
   ✔  - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/61556#pullrequestreview-3770404667
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/61556#pullrequestreview-3822560259
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/61556#pullrequestreview-3835624781
   ✔  - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/61556#pullrequestreview-4068182347
   ✔  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/61556#pullrequestreview-4016624350
   ✘  1 GitHub CI job(s) failed:
   ✘    - Cleanup artifacts: FAILURE (https://github.com/nodejs/node/actions/runs/23858701046/job/69559818402)
   ℹ  Last Full PR CI on 2026-04-07T11:13:20Z: https://ci.nodejs.org/job/node-test-pull-request/72532/
- Querying data for job/node-test-pull-request/72532/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/24082735401

ovflowd · 2026-04-07T13:45:00Z

You gotta be kidding me.... @aduh95 do you know how we can bypass https://github.com/nodejs/node/actions/runs/23858701046/job/69559818402? Seems like just a random Copilot error? IDK if retriggering Copilot would ignore that?

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lib/util.js

doc/api/util.md

nodejs-github-bot · 2026-04-07T14:17:00Z

Commit Queue failed

- Loading data for nodejs/node/pull/61556
✔  Done loading data for nodejs/node/pull/61556
----------------------------------- PR info ------------------------------------
Title      util: add hex colors support in `styleText` (#61556)
Author     Guilherme Araújo <arauujogui@gmail.com> (@araujogui)
Branch     araujogui:util/colorize-hex -> nodejs:main
Labels     util, semver-minor, author ready, needs-ci, commit-queue-squash
Commits    9
 - util: colorize text with hex colors
 - util: nits
 - util: non-capturing regex
 - util: return buffer
 - doc: add history entry
 - doc: add final period
 - doc: profread
 - util: remove unused import
 - benchmark: add hex style
Committers 1
 - Guilherme Araújo <arauujogui@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/61556
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61556
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 28 Jan 2026 01:00:57 GMT
   ✔  Approvals: 8
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/61556#pullrequestreview-3723149200
   ✔  - Jordan Harband (@ljharb): https://github.com/nodejs/node/pull/61556#pullrequestreview-3724564626
   ✔  - René (@Renegade334): https://github.com/nodejs/node/pull/61556#pullrequestreview-3769858571
   ✔  - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/61556#pullrequestreview-3770404667
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/61556#pullrequestreview-3822560259
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/61556#pullrequestreview-3835624781
   ✔  - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/61556#pullrequestreview-4068182347
   ✔  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/61556#pullrequestreview-4016624350
   ✘  1 GitHub CI job(s) failed:
   ✘    - Cleanup artifacts: FAILURE (https://github.com/nodejs/node/actions/runs/23858701046/job/69559818402)
   ℹ  Last Full PR CI on 2026-04-07T13:03:37Z: https://ci.nodejs.org/job/node-test-pull-request/72532/
- Querying data for job/node-test-pull-request/72532/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/24086140240

nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Jan 28, 2026

ljharb reviewed Jan 28, 2026

View reviewed changes

lib/util.js Outdated Show resolved Hide resolved

lib/util.js Outdated Show resolved Hide resolved

lib/util.js Outdated Show resolved Hide resolved

Renegade334 reviewed Jan 28, 2026

View reviewed changes

lib/util.js Outdated Show resolved Hide resolved

araujogui force-pushed the util/colorize-hex branch from e4dff45 to 012abfa Compare January 28, 2026 23:54

araujogui requested review from Renegade334 and ljharb January 28, 2026 23:55

targos approved these changes Jan 29, 2026

View reviewed changes

Renegade334 reviewed Jan 29, 2026

View reviewed changes

lib/util.js Outdated Show resolved Hide resolved

lib/util.js Show resolved Hide resolved

araujogui requested a review from Renegade334 January 29, 2026 18:50

ljharb approved these changes Jan 29, 2026

View reviewed changes

lib/util.js Outdated Show resolved Hide resolved

Renegade334 approved these changes Feb 8, 2026

View reviewed changes

lib/util.js Outdated Show resolved Hide resolved

Renegade334 approved these changes Feb 8, 2026

View reviewed changes

Renegade334 added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 8, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 8, 2026

This comment was marked as outdated.

Sign in to view

gurgunday approved these changes Feb 8, 2026

View reviewed changes

gurgunday added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 8, 2026

aduh95 added the semver-minor PRs that contain new features and should be released in the next minor version. label Feb 18, 2026

aduh95 reviewed Feb 18, 2026

View reviewed changes

doc/api/util.md Show resolved Hide resolved

aduh95 reviewed Feb 18, 2026

View reviewed changes

doc/api/util.md Outdated Show resolved Hide resolved

aduh95 approved these changes Feb 18, 2026

View reviewed changes

aduh95 added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Feb 18, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2026

araujogui force-pushed the util/colorize-hex branch from 8eb2649 to e90ab1c Compare February 19, 2026 13:35

RafaelGSS reviewed Feb 19, 2026

View reviewed changes

araujogui added 2 commits April 1, 2026 13:13

util: remove unused import

00ef37b

benchmark: add hex style

c01e52b

Copilot AI review requested due to automatic review settings April 1, 2026 16:14

araujogui force-pushed the util/colorize-hex branch from f943683 to c01e52b Compare April 1, 2026 16:14

Copilot started reviewing on behalf of araujogui April 1, 2026 16:15 View session

Copilot AI reviewed Apr 1, 2026

View reviewed changes

test/parallel/test-util-styletext-hex.js Show resolved Hide resolved

test/parallel/test-util-styletext-hex.js Show resolved Hide resolved

lib/util.js Show resolved Hide resolved

lib/util.js Show resolved Hide resolved

ovflowd added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 2, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 2, 2026

ovflowd added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 7, 2026

ovflowd approved these changes Apr 7, 2026

View reviewed changes

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 7, 2026

ovflowd requested a review from Copilot April 7, 2026 13:45

Copilot started reviewing on behalf of ovflowd April 7, 2026 13:46 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

lib/util.js Show resolved Hide resolved

lib/util.js Show resolved Hide resolved

doc/api/util.md Show resolved Hide resolved

doc/api/util.md Show resolved Hide resolved

ovflowd added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 7, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 7, 2026

Uh oh!

Conversation

araujogui commented Jan 28, 2026

Uh oh!

codecov bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ljharb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Feb 8, 2026

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 18, 2026

Uh oh!

RafaelGSS left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

araujogui commented Apr 1, 2026

Uh oh!

nodejs-github-bot commented Apr 2, 2026

Uh oh!

nodejs-github-bot commented Apr 6, 2026

Uh oh!

nodejs-github-bot commented Apr 6, 2026

Uh oh!

nodejs-github-bot commented Apr 6, 2026

Uh oh!

ovflowd commented Apr 6, 2026

Uh oh!

nodejs-github-bot commented Apr 7, 2026

Uh oh!

nodejs-github-bot commented Apr 7, 2026

Uh oh!

nodejs-github-bot commented Apr 7, 2026

Uh oh!

ovflowd commented Apr 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

codecov bot commented Jan 28, 2026 •

edited

Loading